2.x: fix PublishProcessor cancel/emission overflow bug #5669
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should fix the bug that caused the test failure in #5545.
The bug manifested itself when a cancellation was happening the same time a request 1 was being fulfilled. Since the same request accounting was used for cancellation indicator, if the cancel happened between the
onNext()
'sget()
check anddecrementAndGet
, thisdecrementAndGet
decremented Long.MIN_VALUE unconditionally, which lead to a state that would appear the Subscriber still can receive events. A concurrentoffer
, which saves the current array of registeredSubscriber
s, then would emit an item and overflow theSubscriber
.The fix is to use the cancellation-aware
BackpressureHelper.producedCancel()
utility.Unit test were added to verify the correct behavior on both
PublishProcessor
andBehaviorProcessor
(the latter uses different cancellation mechanism via a dedicated field).