Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nullPointerException comments and ObjectHelper test code. #5255

Merged
merged 2 commits into from
Apr 1, 2017

Conversation

ggikko
Copy link
Contributor

@ggikko ggikko commented Apr 1, 2017

:)

@codecov
Copy link

codecov bot commented Apr 1, 2017

Codecov Report

Merging #5255 into 2.x will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##                2.x    #5255      +/-   ##
============================================
+ Coverage     95.97%   95.98%   +<.01%     
- Complexity     5741     5747       +6     
============================================
  Files           628      628              
  Lines         41075    41075              
  Branches       5698     5698              
============================================
+ Hits          39420    39424       +4     
+ Misses          660      655       -5     
- Partials        995      996       +1
Impacted Files Coverage Δ Complexity Δ
src/main/java/io/reactivex/Observable.java 100% <ø> (ø) 506 <0> (ø) ⬇️
...ors/observable/ObservableSampleWithObservable.java 92.77% <0%> (-6.03%) 3% <0%> (ø)
...ternal/operators/flowable/FlowableSampleTimed.java 91.17% <0%> (-4.42%) 3% <0%> (ø)
...rnal/operators/completable/CompletableTimeout.java 94% <0%> (-4%) 2% <0%> (ø)
...ernal/operators/maybe/MaybeTakeUntilPublisher.java 96% <0%> (-4%) 2% <0%> (ø)
...activex/internal/subscribers/FutureSubscriber.java 96.82% <0%> (-3.18%) 32% <0%> (-1%)
...al/operators/observable/ObservableSampleTimed.java 95% <0%> (-1.67%) 3% <0%> (ø)
...perators/single/SingleFlatMapIterableFlowable.java 96.66% <0%> (-1.67%) 2% <0%> (ø)
...rnal/operators/flowable/FlowableFlatMapSingle.java 95.05% <0%> (-1.65%) 2% <0%> (ø)
.../operators/observable/ObservableFlatMapSingle.java 93.28% <0%> (-1.5%) 2% <0%> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6c8b0ef...f3e32aa. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants