-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
2.x: Fix wrong comments in Functions.java “Function3” -> “BiFunction” #5230
Merged
Merged
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
38a1965
Fix wrong comments in Functions.java “Function3” -> “BiFunction”
ggikko 73a285d
Add “toFunction” fail test from Bifurcation to Function9
ggikko 03220b4
Update FunctionsTest.java
ggikko 00bd4c7
Change comments “BiFunction..Function9” - > “BiFunction, Function3..F…
ggikko 1524557
Add @SuppressWarnings({"unchecked", "rawtypes"}) into Functions fail …
ggikko File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -169,6 +169,54 @@ public Integer apply(Integer t1, Integer t2, Integer t3, Integer t4, Integer t5, | |
}).apply(new Object[20]); | ||
} | ||
|
||
@Test(expected = NullPointerException.class) | ||
public void biFunctionFail() throws Exception { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please add There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thank you for comment. |
||
BiFunction biFunction = null; | ||
Functions.toFunction(biFunction); | ||
} | ||
|
||
@Test(expected = NullPointerException.class) | ||
public void function3Fail() throws Exception { | ||
Function3 function3 = null; | ||
Functions.toFunction(function3); | ||
} | ||
|
||
@Test(expected = NullPointerException.class) | ||
public void function4Fail() throws Exception { | ||
Function4 function4 = null; | ||
Functions.toFunction(function4); | ||
} | ||
|
||
@Test(expected = NullPointerException.class) | ||
public void function5Fail() throws Exception { | ||
Function5 function5 = null; | ||
Functions.toFunction(function5); | ||
} | ||
|
||
@Test(expected = NullPointerException.class) | ||
public void function6Fail() throws Exception { | ||
Function6 function6 = null; | ||
Functions.toFunction(function6); | ||
} | ||
|
||
@Test(expected = NullPointerException.class) | ||
public void function7Fail() throws Exception { | ||
Function7 function7 = null; | ||
Functions.toFunction(function7); | ||
} | ||
|
||
@Test(expected = NullPointerException.class) | ||
public void function8Fail() throws Exception { | ||
Function8 function8 = null; | ||
Functions.toFunction(function8); | ||
} | ||
|
||
@Test(expected = NullPointerException.class) | ||
public void function9Fail() throws Exception { | ||
Function9 function9 = null; | ||
Functions.toFunction(function9); | ||
} | ||
|
||
@Test | ||
public void identityFunctionToString() { | ||
assertEquals("IdentityFunction", Functions.identity().toString()); | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually,
BiFunction, Function3..Function9
would be better.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree.