1.x: create+subscribeOn avoid same-pool deadlock #5091
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to fix the same-pool deadlock that may happen with
create()(formerlyfromEmitter) andsubscribeOnassubscribeOnby default schedules the requests behind a running emitter and thus the internal request amount may not get updated, leading to unnecessary dataloss.See #4735.
In the update, if
subscribeOndetects its upstream isOnSubscribeCreate, it no longer reschedules requests for it. For other, non-immediate cases, a new overload allows specifying therequestOnparameter that should befalseif there is acreate(Action1, BackpressureStrategy)in the sequence upstream.