1.x: deprecate create(), add alternatives #5086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report@@ Coverage Diff @@
## 1.x #5086 +/- ##
============================================
- Coverage 84.24% 84.24% -0.01%
Complexity 2859 2859
============================================
Files 288 288
Lines 17805 17807 +2
Branches 2420 2420
============================================
+ Hits 15000 15001 +1
- Misses 1954 1955 +1
Partials 851 851
Continue to review full report at Codecov.
|
JakeWharton
approved these changes
Feb 10, 2017
| * @see rx.functions.Cancellable | ||
| * @since 1.2.7 - experimental | ||
| */ | ||
| @Experimental |
There was a problem hiding this comment.
The lack of a stable fromEmitter and now two-argument create() is quite a burden on libraries. I would love to see this go to stable in 1.3 (skipping @Beta).
| */ | ||
| @Experimental | ||
| @Deprecated |
| @@ -49,7 +49,7 @@ public void before() { | |||
|
|
|||
There was a problem hiding this comment.
nit: this file needs renamed
akarnokd
force-pushed
the
UnsafeCreate
branch
from
2027ff0 to
a072448
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
create()won't go away unless we get the IDE mark it someway, such as being deprecated.This PR deprecates
create()and addsunsafeCreatefor internal use and deprecate-renamesfromEmittertocreate(Action1, BackpressureMode).There was an earlier attempt at deprecating
create, #4253, but it was not followed up. This PR executes what I suggested in one of the comments.