2.x: ExecutorScheduler.scheduleDirect to report isDisposed on complete #5005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.61% (diff: 79.31%)@@ 2.x #5005 diff @@
==========================================
Files 592 592
Lines 37989 38011 +22
Methods 0 0
Messages 0 0
Branches 5772 5777 +5
==========================================
+ Hits 36257 36346 +89
+ Misses 764 720 -44
+ Partials 968 945 -23
|
JakeWharton
approved these changes
Jan 18, 2017
| if (getAndSet(null) != null) { | ||
| timed.dispose(); | ||
| timed.dispose(); | ||
| } |
akarnokd
force-pushed
the
SchedulerIsDisposedFix
branch
from
8a7f2ec to
dd0c96d
Compare
This was referenced Jan 18, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the
Disposablereturned by theExecutorScheduler.scheduleDirect()reportisDisposedtrueif the task has actually finished, which should now be consistent with theWorkerbehavior of other schedulers.Reported in #5004.