2.x: make Obs.combineLatest consistent with Flowable + doc cornercase #4987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JakeWharton
approved these changes
Jan 12, 2017
Current coverage is 95.62% (diff: 100%)@@ 2.x #4987 diff @@
==========================================
Files 592 592
Lines 37968 37968
Methods 0 0
Messages 0 0
Branches 5752 5752
==========================================
- Hits 36307 36306 -1
Misses 701 701
- Partials 960 961 +1
|
|
ya
…On Jan 12, 2017 9:25 PM, "David Karnok" ***@***.***> wrote:
Merged #4987 <#4987>.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#4987 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AGhr1dW7YfbfY8Ya_T8bHXvx8rQIVj_aks5rRnAfgaJpZM4LiArG>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
Observable.combineLatestto be consistent withFlowable.combineLatestby not subscribing to additional input sources if the operator reached a terminal state due to a valueless source (that completes or errors). In addition, such early termination didn't properly cancel the other sources whendelayErrors == true.I've also extended the documentation on the overloads to warn about empty sources that will terminate the operator, even with
combineLatestDelayError, and thus subscription side-effects may not happen.There is a related issue #4414 where the operator should fully consume each input source no matter what and terminate when all terminate. I'm still considering what would be the best way to introduce this.
Reported in #4986