Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Javadoc improvements #487

Closed
wants to merge 2 commits into from
Closed

Javadoc improvements #487

wants to merge 2 commits into from

Conversation

DavidMGross
Copy link
Collaborator

Adding marble diagrams, making the javadocs more consistent in their terminology & formatting.

@DavidMGross
Marble diagrams for Subject subclasses
128ffc5 
Adding marble diagrams and making the javadoc descriptions match the
terminology used elsewhere in the docs (e.g. "emit", "item")
@DavidMGross
javadoc changes
28032ba 
added marble diagrams, standardized terminology and formatting
@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #412 FAILURE
Looks like there's a problem with this pull request

@benjchristensen
Copy link
Member

David, this is conflicting and can't merge.

@DavidMGross
Copy link
Collaborator Author

Yeah. I'm trying to move over to sourcetree and I'm still climbing the
learning curve. I think I still find git a little baffling in terms of what
things I do are local and what things affect the shared repository.

I tried to merge just the changes in Observable.java w/o the ones in other
files, but I'm not sure if I successfully pushed my results. I'll try to
be more methodical today and see if I can get it right.

On Mon, Nov 18, 2013 at 8:35 PM, Ben Christensen
[email protected]:

David, this is conflicting and can't merge.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/487#issuecomment-28764596
.

David M. Gross
PLP Consulting

jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
@RobWin
Issue ReactiveX#486: Added threadpool bulkhead to resilience4j-ratpac…
3f03143 
…k, some refactoring (ReactiveX#487)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavidMGross @cloudbees-pull-request-builder @benjchristensen