2.x: Fix exceptions in javaDoc #4793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DmitriyZaitsev
changed the title
akarnokd
approved these changes
Nov 2, 2016
DmitriyZaitsev
force-pushed
the
dz/2.x/fix_javadoc_exceptions
branch
from
f3d43db to
f9c4a16
Compare
Current coverage is 95.69% (diff: 100%)@@ 2.x #4793 diff @@
==========================================
Files 570 570
Lines 36717 36717
Methods 0 0
Messages 0 0
Branches 5554 5554
==========================================
- Hits 35153 35138 -15
- Misses 639 649 +10
- Partials 925 930 +5
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've corrected some javadocs for methods that check arguments using
ObjectHelper.requireNonNull(arg, "message"). It throwsNullPointerExceptioninstead ofIllegalArgumentException, but as we know copy-pasting is an insidious thing. ;)