2.x: fix Observable.repeatWhen & retryWhen not disposing the inner #4783
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Observer
that is subscribing to theObservable
returned by the handler function was not properly linked to the disposing of the end Observer. This PR fixes it by making thatObserver
do asyncDisposable
management and make sure the endObserver
receives a disposable list with both the main and the handlerDisposable
s.The
Flowable
versions worked properly but added unit tests to them regardless.Reported in #4782.