Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added 'sleep' to avoid 'testMapWithErrorInFuncAndThreadPoolScheduler' fails #461

Closed
wants to merge 2 commits into from
Closed

Added 'sleep' to avoid 'testMapWithErrorInFuncAndThreadPoolScheduler' fails #461

wants to merge 2 commits into from

Conversation

zsxwing
Copy link
Member

@zsxwing zsxwing commented Nov 1, 2013

Hi, due to my mistake, testMapWithErrorInFuncAndThreadPoolScheduler may fail in some situation. Sorry for that. I fixed it in this PR.

@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #380 FAILURE
Looks like there's a problem with this pull request

@benjchristensen
Copy link
Member

It is preferable to use a CountDownLatch instead of sleep, or the TestScheduler. CloudBees in particular demonstrates the non-determinism of Thread.sleep for unit tests.

@zsxwing
Copy link
Member Author

zsxwing commented Nov 3, 2013

I updated the PR and used TestScheduler.

@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #381 FAILURE
Looks like there's a problem with this pull request

@benjchristensen
Copy link
Member

Due to pull request #466 which touched virtually every file in the project can you please rebase this so it can merge cleanly again?

@zsxwing
Copy link
Member Author

zsxwing commented Nov 5, 2013

I have rebased it.

@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #389 FAILURE
Looks like there's a problem with this pull request

@zsxwing zsxwing mentioned this pull request Nov 6, 2013
Closed
@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #392 FAILURE
Looks like there's a problem with this pull request

@zsxwing zsxwing mentioned this pull request Nov 6, 2013
Closed
@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #393 FAILURE
Looks like there's a problem with this pull request

@cloudbees-pull-request-builder
Copy link

RxJava-pull-requests #394 FAILURE
Looks like there's a problem with this pull request

@zsxwing zsxwing closed this Nov 8, 2013
@zsxwing
Copy link
Member Author

zsxwing commented Nov 8, 2013

It has been fixed in #473

@zsxwing zsxwing deleted the fix-unit-test branch November 8, 2013 03:29
@zsxwing zsxwing restored the fix-unit-test branch November 8, 2013 03:29
@zsxwing zsxwing deleted the fix-unit-test branch November 8, 2013 03:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@zsxwing @cloudbees-pull-request-builder @benjchristensen @abersnaze