2.x: fixes, cleanup, coverage 8/31-1 #4450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 75.82% (diff: 69.75%)@@ 2.x #4450 diff @@
==========================================
Files 454 454
Lines 32274 32200 -74
Methods 0 0
Messages 0 0
Branches 5209 5178 -31
==========================================
+ Hits 24322 24417 +95
+ Misses 5914 5769 -145
+ Partials 2038 2014 -24
|
| @@ -5086,7 +5086,7 @@ public final T blockingSingle(T defaultItem) { | |||
| * @see <a href="http://reactivex.io/documentation/operators/to.html">ReactiveX documentation: To</a> | |||
| */ | |||
| public final Future<T> toFuture() { | |||
| return FlowableToFuture.toFuture(this); | |||
| return subscribeWith(new FutureSubscriber<T>()); | |||
|
👍 |
This was referenced Aug 31, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Single.subscribeOnandCompletable.subscribeOndisposable management.FutureSubscriberandFutureObserverclasses, drop their former enumsDisposables.frommethods, addDisposables.fromXmethods where X = argument typeCompletable.mergeXoperators.