Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Completable.andThen(Completable), deprecate endWith() #3948

Merged
merged 3 commits into from
May 23, 2016
Merged

Add Completable.andThen(Completable), deprecate endWith() #3948

merged 3 commits into from
May 23, 2016

Conversation

vanniktech
Copy link
Collaborator

@vanniktech vanniktech commented May 18, 2016

See #3947

@akarnokd akarnokd changed the title Completable.andThen(Completable). Fixes #3947 Add Completable.andThen(Completable), deprecate endWith() May 18, 2016
@akarnokd
Copy link
Member

Please update unit tests that use these deprecated methods.

@vanniktech
Copy link
Collaborator Author

Done.

@akarnokd
Copy link
Member

👍

@artem-zinnatullin
Copy link
Contributor

👍 but I'd either duplicate tests or make universal test functions and test both endWith and andThen to make sure that we don't break old behavior of public api.

@vanniktech
Copy link
Collaborator Author

The question is also since Completable is still @Experimental we could if this is wanted go the hard way and remove the deprecated methods and make everyone force to use the standard (new) methods since there are already quite a few deprecated / duplicated methods.

@zsxwing
Copy link
Member

zsxwing commented May 23, 2016

👍

but I'd either duplicate tests or make universal test functions and test both endWith and andThen to make sure that we don't break old behavior of public api.

@artem-zinnatullin I'm not against it but this is really minor as andThen just calls endWith. I'm going to merge this. Feel free to add tests in a separate PR if you wish.

@zsxwing zsxwing closed this May 23, 2016
@zsxwing zsxwing reopened this May 23, 2016
@zsxwing zsxwing merged commit c296d52 into ReactiveX:1.x May 23, 2016
@vanniktech vanniktech deleted the 1.x_completable_and_then branch May 24, 2016 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants