1.x: fix filter() default-requesting and thus going unbounded #3912
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Agree. Not sure if you can release with 1.1.4.1 or you have to roll to 1.1.5. |
|
Does |
|
No. Map doesn't set the Producer on |
|
Ah, that's right. I think I made the same mistake on the first PR, too. On Thu, May 5, 2016 at 3:32 PM David Karnok [email protected]
|
EddieRingle
added a commit
to EddieRingle/RxAndroid
that referenced
this pull request
May 10, 2016
RE: ReactiveX/RxJava#3912 Signed-off-by: Eddie Ringle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgot that
Subscriberdefaults to requestingLong.MAX_VALUEunless suppressed and apparently there was no verification of filter's backpressure behavior; the two existing tests didn't really check for the delivery pattern.