Have undeliverable errors on subscribe() sent to plugin error handler. #3887
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will make sure if the
Subscriber
has unsubscribed, the non-fatal error is sent to the plugin error handler at least. I.e.,In addition, if the original code threw
RuntimeException
in case thesubscriber.onError()
threw. I've changed this toOnErrorFailedException
but not sure the original type was intentional or just left out.