Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have undeliverable errors on subscribe() sent to plugin error handler. #3887

Merged
merged 1 commit into from
Apr 29, 2016

Conversation

akarnokd
Copy link
Member

This change will make sure if the Subscriber has unsubscribed, the non-fatal error is sent to the plugin error handler at least. I.e.,

Observable.create(s -> {
    s.onError(new RuntimeException());
    throw new IllegalArgumentException();
}).subscribe();

In addition, if the original code threw RuntimeException in case the subscriber.onError() threw. I've changed this to OnErrorFailedException but not sure the original type was intentional or just left out.

@stevegury
Copy link
Member

👍

@akarnokd akarnokd merged commit e58c4a7 into ReactiveX:1.x Apr 29, 2016
@akarnokd akarnokd deleted the OnSubscribeNoSwallow branch April 29, 2016 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants