1.x: Add Completable.andThen(Single) #3799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| }; | ||
|
|
||
| final SerialSubscription serial = new SerialSubscription(); |
|
thanks for your review. fixed |
| * Returns a Single which will subscribe to this Completable and once that is completed then | ||
| * will subscribe to the {@code next} Single. An error event from this Completable will be | ||
| * propagated to the downstream subscriber and will result in skipping the subscription of the | ||
| * Observable. |
There was a problem hiding this comment.
Observable -> Single
|
Looks good! 👍 Just few small things to fix. |
|
@artem-zinnatullin @akarnokd thanks for your review. i'll update this soon. |
|
Updated and rebased. |
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#3730