Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

1.x: combineLatestDelayError #3763

Merged
merged 1 commit into from
Mar 14, 2016

Conversation

akarnokd
Copy link
Member

This PR exposes the delayError option in combineLatest as combineLatestDelayError.

(Note that we have convenience overloads with 2-9 sources that could also use an overload, but that just expands the API surface drastically.)

TestSubscriber<Integer> ts = TestSubscriber.create();

Observable.combineLatestDelayError(
Arrays.asList(Observable.just(1), Observable.<Integer>error(new TestException())),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this should be in secondJustError() and vice versa

@artem-zinnatullin
Copy link
Contributor

👍

(I'm starting feeling bad for guy who asked for Map with indexes, since his request we added so many overloads of other operators…)

@abersnaze
Copy link
Contributor

👍

abersnaze added a commit that referenced this pull request Mar 14, 2016
@abersnaze abersnaze merged commit a42d0bf into ReactiveX:1.x Mar 14, 2016
@akarnokd akarnokd deleted the CombineLatestDelayError1x branch March 14, 2016 22:13
@stevegury
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants