Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add maxConcurrent parameter to flatMapIterable #3722

Merged
merged 1 commit into from
Mar 3, 2016
Merged

Add maxConcurrent parameter to flatMapIterable #3722

merged 1 commit into from
Mar 3, 2016

Conversation

lukaciko
Copy link

Refs #3711. Should these new overloaded functions be annotated with @Beta?

@lukaciko
Copy link
Author

The failing test (testNoMoreRequestsAfterUnsubscribe) seems unrelated. All tests pass locally.

@akarnokd
Copy link
Member

If you could add one unit test for each method that verifies maxConcurrent is honored, that would be great.

@lukaciko
Copy link
Author

While writing the test I figured you might have been right when commenting on issue #2627. If I am not mistaken all the observables created with OperatorMapPair.convertSelector use the same scheduler (there is no way to subscribe them to different schedulers) and thus are run sequentially and until completion. Would adding a Scheduler parameter make sense?

@akarnokd
Copy link
Member

There is no scheduler involved here so no.

@akarnokd
Copy link
Member

akarnokd commented Mar 3, 2016

👍 as it is now

@stevegury
Copy link
Member

👍

stevegury added a commit that referenced this pull request Mar 3, 2016
Add maxConcurrent parameter to flatMapIterable
@stevegury stevegury merged commit 2343989 into ReactiveX:1.x Mar 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants