-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added retry and retryWhen support for Single #3686
Conversation
@@ -1,45 +1,18 @@ | |||
/** | |||
* Copyright 2015 Netflix, Inc. | |||
* | |||
* <p/> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happened to the header?
Please don't unroll |
My codestyle settings messed everything a bit. Is there a exported codestyle.xml file or something similar so I could import into my IDE? |
Not really. Also please squash your commits. |
* | ||
* <img width="640" height="315" src="https://raw.github.com/wiki/ReactiveX/RxJava/images/rx-operators/retry.png" alt=""> | ||
* | ||
* If the source Single calls {@link Observer#onError}, this method will resubscribe to the source |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
SingleSubscriber#onError
Could you also fix those 1 spaces removed everywhere? |
I have fixed all reported problems. |
@@ -1,50 +1,37 @@ | |||
/** | |||
* Copyright 2015 Netflix, Inc. | |||
* | |||
* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These space removals are still there. Are you using IntelliJ? I'm sure there is a way to disable the remove whitespace from line ends option.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes I am using Intellij. Ok I will check.
Something went really wrong. I merged latest changes from upstream 1.x to my 1.x branch. |
In this case, I'd just start from a clean branch of master and reapply/merge my customizations. |
I managed to fix it. Now I just need to sort out the missing spaces. |
This looks much better. 👍 |
👍 |
Added retry and retryWhen support for Single
No description provided.