1.x: change publish(Func1) to use a dedicated subject-like dispatcher #3681
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akarnokd
force-pushed
the
PublishMulticast1x
branch
from
9ab199a to
51c9491
Compare
|
Updated with more unit tests and behavior clarification/validation ( |
|
|
||
| ts.requestMore(RxRingBuffer.SIZE); | ||
|
|
||
| ts.assertValueCount(128); |
There was a problem hiding this comment.
Should you use RxRingBuffer.SIZE here?
|
Other than this minor comment, 👍 |
akarnokd
force-pushed
the
PublishMulticast1x
branch
from
51c9491 to
3a87dcb
Compare
akarnokd
added a commit
that referenced
this pull request
Feb 11, 2016
1.x: change publish(Func1) to use a dedicated subject-like dispatcher
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Solves the problems #3673 and #3674 by introducing a new subject-like dispatcher class
OnSubscribePublishMulticastthat does support backpressure, pauses when there are no subscribers and signals the terminal event for late subscribers; all ideal for the multicastingpublish(Func1)overload.