-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
1.x: Add Single.onErrorResumeNext(Single) #3655
1.x: Add Single.onErrorResumeNext(Single) #3655
Conversation
import rx.exceptions.Exceptions; | ||
import rx.plugins.RxJavaPlugins; | ||
|
||
public class SingleOperatorOnErrorResumeNextViaSingle<T> implements Operator<T, T> { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not implement this via SingleOnSubscribe and then you have access to SingleSubscriber without the API mismatch with backpressured Operators?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, will do.
On Fri, 29 Jan 2016, 11:08 David Karnok [email protected] wrote:
In
src/main/java/rx/internal/operators/SingleOperatorOnErrorResumeNextViaSingle.java
#3655 (comment):@@ -0,0 +1,67 @@
+package rx.internal.operators;
+
+import rx.Observable.Operator;
+import rx.Producer;
+import rx.Single;
+import rx.Subscriber;
+import rx.exceptions.Exceptions;
+import rx.plugins.RxJavaPlugins;
+
+public class SingleOperatorOnErrorResumeNextViaSingle implements Operator<T, T> {Why not implement this via SingleOnSubscribe and then you have access to
SingleSubscriber without the API mismatch with backpressured Operators?—
Reply to this email directly or view it on GitHub
https://github.com/ReactiveX/RxJava/pull/3655/files#r51234767.
@artem_zin
0c44ad2
to
67ef32c
Compare
@akarnokd changed to |
👍 |
@zsxwing PTAL :) |
👍 |
…extViaSingle 1.x: Add Single.onErrorResumeNext(Single)
👍 |
Part of #3652, will submit a PR for
onErrorResumeNext(Func1<Throwable, Single>)
later.