1.x: Added MergeDelay operators for Iterable of Observables #3627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
akarnokd
changed the title
| * Observables in the Iterable | ||
| * @see <a href="http://reactivex.io/documentation/operators/merge.html">ReactiveX operators documentation: Merge</a> | ||
| */ | ||
| public final static <T> Observable<T> mergeDelayError(Iterable<? extends Observable<? extends T>> sequences) { |
There was a problem hiding this comment.
Please remove final
|
Just few things about code style, otherwise LGTM 👍 |
| @@ -272,6 +272,23 @@ public void testMergeList() { | |||
| verify(stringObserver, times(2)).onNext("hello"); | |||
| } | |||
|
|
|||
| // This is pretty much a clone of testMergeList but with the overloaded MergeDelayError for Iterables | |||
| @Test | |||
| public void MergeIterable() { | |||
There was a problem hiding this comment.
nit: MergeIterable -> mergeIterable
|
👍 once you fix the style issue |
|
👍 after renaming the |
|
👍 @JohnWowUs can you please squash commits in your PR into one? |
|
@JohnWowUs could you squash commits? Thanks! |
JohnWowUs
force-pushed
the
mergeDelayIterable
branch
from
a5c70ca to
d179699
Compare
|
Done. |
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Feb 8, 2016
1.x: Added MergeDelay operators for Iterable of Observables
This was referenced Feb 9, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for issue #3577