1.x: No more need to convert Singles to Observables for Single.zip() #3579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
artem-zinnatullin
force-pushed
the
single-zip-no-more-as-observable
branch
from
6b8b630 to
57dd6d9
Compare
|
👍 |
| @@ -966,8 +966,13 @@ public void onError(Throwable error) { | |||
| * @return a Single that emits the zipped results | |||
| * @see <a href="http://reactivex.io/documentation/operators/zip.html">ReactiveX operators documentation: Zip</a> | |||
| */ | |||
| public final static <T1, T2, R> Single<R> zip(Single<? extends T1> o1, Single<? extends T2> o2, final Func2<? super T1, ? super T2, ? extends R> zipFunction) { | |||
| return just(new Observable<?>[] { asObservable(o1), asObservable(o2) }).lift(new OperatorZip<R>(zipFunction)); | |||
| public static <T1, T2, R> Single<R> zip(Single<? extends T1> s1, Single<? extends T2> s2, final Func2<? super T1, ? super T2, ? extends R> zipFunction) { | |||
There was a problem hiding this comment.
or remove final from all static methods in another PR
There was a problem hiding this comment.
I'm for the removal as well, it's redundant. (I also remember an argument about it some time back.)
|
Could you add |
akarnokd
changed the title
artem-zinnatullin
force-pushed
the
single-zip-no-more-as-observable
branch
from
57dd6d9 to
f5716b4
Compare
artem-zinnatullin
force-pushed
the
single-zip-no-more-as-observable
branch
from
f5716b4 to
b4a6fdd
Compare
|
Sorry, was busy… @zsxwing added |
|
👍 |
akarnokd
added a commit
that referenced
this pull request
Jan 24, 2016
…-observable 1.x: No more need to convert Singles to Observables for Single.zip()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PTAL