Add Single.doOnError() #3419
Merged
Add Single.doOnError() #3419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /** | ||
| * Modifies the source {@link Single} so that it invokes an action if it calls {@code onError}. | ||
| * <p> | ||
| * In case the onError action throws, the downstream will receive a composite exception containing |
There was a problem hiding this comment.
Could you add an unit test that verifies this?
There was a problem hiding this comment.
Added doOnErrorShouldThrowCompositeExceptionIfOnErrorActionThrows()
| * @return the source {@link Single} with the side-effecting behavior applied | ||
| * @see <a href="http://reactivex.io/documentation/operators/do.html">ReactiveX operators documentation: Do</a> | ||
| */ | ||
| public final Single<T> doOnError(final Action1<Throwable> onError) { |
There was a problem hiding this comment.
This should start out as experimental unless the RxJava contributors want to fast-track this.
There was a problem hiding this comment.
Added @Experimental
artem-zinnatullin
force-pushed
the
single-do-on-error
branch
from
3f6e2db to
2d832a4
Compare
|
👍 |
1 similar comment
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.