Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix TestSubject bug #2936

Merged
merged 3 commits into from
May 7, 2015
Merged

Fix TestSubject bug #2936

merged 3 commits into from
May 7, 2015

Conversation

jacek-marchwicki
Copy link
Contributor

Info

Problem is in TestSubject.onNext()
when is called on current time that is not 0 it will be delayed by current time.
calling TestSubject.onNext() should execute immediately.

Tests

  • TestSubjectTest.testObserverPropagateValueAfterTriggeringActions - represent already working behavior
  • TestSubjectTest.testObserverPropagateValueInFutureTimeAfterTriggeringActions - represent a bug that is fixed by this commit

@akarnokd
Copy link
Member

akarnokd commented May 6, 2015

The same error is present on onError() and onCompleted(). Could you fix those as well?

@jacek-marchwicki
Copy link
Contributor Author

@akarnokd Yep... hold a second

@akarnokd
Copy link
Member

akarnokd commented May 7, 2015

Looks good. Thanks!

akarnokd added a commit that referenced this pull request May 7, 2015
@akarnokd
Merge pull request #2936 from jacek-marchwicki/fix-observer-bug
b3384e0 
Fix TestSubject bug
@akarnokd akarnokd merged commit b3384e0 into ReactiveX:1.x May 7, 2015
@akarnokd akarnokd added the Bug label May 7, 2015
@benjchristensen benjchristensen mentioned this pull request May 19, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jacek-marchwicki @akarnokd