Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OperatorObserveOn - handle request overflow correctly #2921

Merged
merged 2 commits into from
Apr 29, 2015

Conversation

davidmoten
Copy link
Collaborator

Use BackpressureUtils.getAndAddRequest in the Producer in OperatorObserveOn.

Includes unit test that failed on codebase before this change.

…fails on original codebase but passes with change
@akarnokd
Copy link
Member

Looks good, but I don't like what happens in the ObserveOnSubscriber constructor since the half-constructed this may escape through the setProducer call.

If you could just move the code from the line child.add(scheduledUnsubscribe); up until the constructor's end into some init() method and make sure it is called after the object is constucted (near return new ObserveOnSubscriber<T>(scheduler, child);), that would be great.

@akarnokd akarnokd added the Bug label Apr 29, 2015
…oving code to an init() method and calling after construction
@davidmoten
Copy link
Collaborator Author

Ok, done. Haven't squashed commits because I think worthwhile having as a separate entry in the history.

@akarnokd
Copy link
Member

Great, thanks!

akarnokd added a commit that referenced this pull request Apr 29, 2015
OperatorObserveOn - handle request overflow correctly
@akarnokd akarnokd merged commit 24dadf1 into ReactiveX:1.x Apr 29, 2015
@benjchristensen benjchristensen mentioned this pull request Apr 30, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants