Observable.from(empty) to emit onComplete even when 0 requested #2899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmoten
changed the title
|
ah erk I need to rebase |
davidmoten
force-pushed
the
from-iter-eager-complete
branch
from
d80d17b to
1f5ed40
Compare
…ted when iterable is empty
davidmoten
force-pushed
the
from-iter-eager-complete
branch
from
1f5ed40 to
1c29e7c
Compare
|
rebased now |
|
Thanks! |
akarnokd
added a commit
that referenced
this pull request
Apr 21, 2015
Observable.from(empty) to emit onComplete even when 0 requested
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per discussion in #2884,
Observable.from(iterable)is preferred to emitonCompletedwheniterableis empty even when nothing has been requested.This PR adds a check on
iterator.hasNextbefore theProduceris assigned and emitsonCompletedimmediately ifhasNextreturns false.Includes unit test that failed on existing code base.