Fix Observable.from(Iterable) race condition #2895
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… calls to the Producer.request with Long.MAX_VALUE could start the fast path twice
|
Thanks! |
akarnokd
added a commit
that referenced
this pull request
Apr 20, 2015
Fix Observable.from(Iterable) race condition
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In
IterableProducerif the first two requests come concurrently and are both forLong.MAX_VALUEthen there is a possible race condition where the fast path is started twice thus emitting some or all elements twice.This PR fixes the race by only allowing the fast path if the current request count is 0 (using
compareAndSet).