Fixes wrong request accounting in AbstractOnSubscribe #2854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| break; | ||
| } | ||
| } | ||
| } else | ||
| if (n > 0 && state.requestCount.getAndAdd(n) == 0) { |
There was a problem hiding this comment.
Use BackpressureUtils.getAndAdd here to avoid request overflow?
There was a problem hiding this comment.
Thanks. I thought I added it because of the visibility changes, but it appears it got lost somewhere.
akarnokd
force-pushed
the
AbstractOnSubscribeRequestFix
branch
from
c7e3b2f to
622b0a9
Compare
| if (!state.subscriber.isUnsubscribed()) { | ||
| do { | ||
| if (n > 0 && BackpressureUtils.getAndAddRequest(state.requestCount, n) == 0) { | ||
| // fast-path |
There was a problem hiding this comment.
move this comment down a line (inside the next if block) for clarity?
|
LGTM beyond trivial changes mentioned above. Thanks @akarnokd for fixing quickly (as usual)! |
akarnokd
force-pushed
the
AbstractOnSubscribeRequestFix
branch
from
622b0a9 to
674327d
Compare
|
Done. |
akarnokd
force-pushed
the
AbstractOnSubscribeRequestFix
branch
from
674327d to
31339a2
Compare
akarnokd
added a commit
that referenced
this pull request
Apr 7, 2015
Fixes wrong request accounting in AbstractOnSubscribe
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2853.