Take/Redo Unsubscribe #1793
Merged
Take/Redo Unsubscribe #1793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…as unsubscribed.
To prevent issues such as ReactiveX#1791
This was referenced Oct 23, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not do further work after unsubscribed.
I added a fix to
takeon top of the change by @alexwen that fixes the source of the issue withtake. It now unsubscribes beforeonNextso side-effects ofonNextsuch asrequest(n)happen afterunsubscribeand thus no further work will be scheduled.I left the changes to
OnSubscribeRedoas they are a good safety net in case another operator has a similar issue astake(an easy bug to creep in) as it does no harm toredoto have theisUnsubscribedcheck going forward.Fixes #1791.