BlockingOperatorNextTest.testSingleSourceManyIterators fix #1775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should we change this to use I'm fine with this as an incremental change, but it is still using concurrency and time, hence wondering if we can solve this with |
benjchristensen
added a commit
that referenced
this pull request
Oct 18, 2014
BlockingOperatorNextTest.testSingleSourceManyIterators fix
|
You can't use a single threaded approach here because the hasNext() signals an interest and blocks. If the source emits while there is no interest, the value is dropped. This is why it needs to run on at least 2 threads and delicately time event emission with consumption. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1655