Compose generics #1762
Merged
Compose generics #1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This seems to make my examples all work while still passing the covariance unit tests we have (and with easier to read generics). @davidmoten @akarnokd @zsxwing can you please review this as well? The Java 8 code I tried is at #1663 (comment) and that code does not compile with current code. |
| @@ -177,14 +177,14 @@ public void call(Subscriber<? super R> o) { | |||
| @SuppressWarnings("unchecked") | |||
| public <R> Observable<R> compose(Transformer<? super T, ? extends R> transformer) { | |||
| // Casting to Observable<R> is type-safe because we know Observable is covariant. | |||
| return (Observable<R>) transformer.call(this); | |||
| return (Observable<R>) ((Transformer<T, ? extends R>) transformer).call(this); | |||
There was a problem hiding this comment.
Since using casting, why not just use the following code:
return ((Transformer<T, R>) transformer).call(this);There was a problem hiding this comment.
That won't compile since Transformer is a Func1 that returns a Observable<? extends R>
There was a problem hiding this comment.
Right. Sorry.
Is Transformer<T, R> extends Func1<Observable<T>, Observable<R>> better? Is there any reason that using Observable<? extends R>.
|
LGTM except my comment. |
|
Manually merged in #1776 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.