Operator Retry with predicate #1271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #1169 SUCCESS |
|
Thanks for implementing this. Should we just keep one of those two instead of both so we don't have to deal with the naming/overload issue? |
|
I don't know, which one to keep? |
|
Probably the one that includes attempts? This is the advanced use case for retry, so it should probably provide both attempts and error. It just feels awkward to need to come up with a new name just so we can have one with @headinthebox Do you have an opinion on this? |
|
Agree with @benjchristensen. If you are using this one, you (should) know what you are doing. |
|
RxJava-pull-requests #1176 SUCCESS |
benjchristensen
added a commit
that referenced
this pull request
May 28, 2014
Operator Retry with predicate
|
Thanks @akarnokd and @headinthebox for the review. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operator Retry with predicate + 1 overload for Issue #1214.
The Func1 version is simply named
retry, the Func2 version is namedretryIfdue to lack of ideas and because to avoid overload resolution issues. I also had to open up the OperatorRetryTest classes a bit.