ReplaySubject with time and size bounds #1192
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
RxJava-pull-requests #1104 FAILURE |
|
RxJava-pull-requests #1105 FAILURE |
|
Nice, people will be happy to have all the functionality on Should we wait until after #1185 to rebase and merge this? I have not yet reviewed this. |
|
I'd review and merge this first and go back to #1185 as it surely needs some rebase anyway. |
| * The weak reference back to the previous node. If that node is not | ||
| * hard-referenced, it will be eventually GCd. | ||
| */ | ||
| final WeakReference<Node<T>> previous; |
There was a problem hiding this comment.
This is unnecessary as noone is walking backwards. A singly-linked list is enough.
|
Closing this as the master merge got messed up. |
|
RxJava-pull-requests #1126 FAILURE |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've implemented the bounded
ReplaySubjectvariants and removed the oldOperatorReplay.CustomReplaySubjectso the variousObservable.replay()now use this version.Note that this is based on the current
SubjectSubscriptionManagerand not my manager from PR #1185. I've copied theReplaySubjectConcurrencyTestto check the concurrency properties.The bounded buffering is implemented via a doubly-linked list where the back reference is a weak reference. This allows keeping a reference to the latest
Nodefor each replayState and once a Node is no longer indexed, it will be removed by GC.A concurrency review would be much appreciated.