New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OperatorDematerialize #1083

Merged

benjchristensen merged 1 commit into ReactiveX:master from akarnokd:OperatorDematerialize

Apr 24, 2014

Member

akarnokd commented Apr 24, 2014

Operator Dematerialize

Issue #1060

Two notes:

Since the dematerialize() is an instance method, there is no correct type parametrization for the operator. Therefore, I just used a raw version in the call.
The original dematerialize could send out two onCompleted or an onError followed by an onCompleted because the materialize() always adds an onCompleted after the raw events. This affected operators due to unsafeSubscribe. This new version ensures this doesn't happen.


          OperatorDematerialize

08085ac

cloudbees-pull-request-builder commented Apr 24, 2014

RxJava-pull-requests #994 SUCCESS
This pull request looks good

akarnokd mentioned this pull request

Operations to rewrite #1060

Closed

57 tasks

benjchristensen merged commit 08085ac into ReactiveX:master

akarnokd deleted the OperatorDematerialize branch

April 24, 2014 21:23

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet