Scala cleanup

[vigdorchik]

Review by @headinthebox and @samuelgruetter.

[cloudbees-pull-request-builder]

RxJava-pull-requests #953 SUCCESS
This pull request looks good

[samuelgruetter]

Does this code still work with older Scala versions where SI-7818 is not yet fixed?

[vigdorchik]

This change is local to rxjava-scala and doesn't affect clients. As long as
we don't support cross-building with the older scala versions, we are ok.
On 14 Apr 2014 14:40, "samuelgruetter" [email protected] wrote:

Does this code still work with older Scala versions where SI-7818https://issues.scala-lang.org/browse/SI-7818is not yet fixed?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/1035#issuecomment-40352810
.

[samuelgruetter]

True, "as long as..." ;-)
But what if someone wants to build it with Scala 2.10.2? I'd find it safer to keep these ascriptions for some time...

[vigdorchik]

I'm fine with that. Can we formalize what level of backwards source compatibility we guarantee?

[cloudbees-pull-request-builder]

RxJava-pull-requests #955 SUCCESS
This pull request looks good

[vigdorchik]

Also scaladoc mentions [[rx.lang.scala.util.Closing]] that I can't find. Is scaladoc obsolete?

[samuelgruetter]

Yes, that's obsolete, fixes are welcome ;-) The whole rx.lang.scala.util package was removed, because it contained only Timestamped (which was replaced by Tuple2) and Opening and Closing (which were replaced by type parameters or Any).

[benjchristensen]

Should this be merged? Is it a breaking change?

[vigdorchik]

Formally that is a breaking change. However I don't expect many users to specify 'Closing' type parameter explicitly. Otherwise source compatibility is preserved.

[cloudbees-pull-request-builder]

RxJava-pull-requests #958 SUCCESS
This pull request looks good

[headinthebox]

Looks good to me. Should have been done together with window.