Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReplaySubject Time and Capacity #865

Closed
benjchristensen opened this issue Feb 12, 2014 · 6 comments
Closed

ReplaySubject Time and Capacity #865

benjchristensen opened this issue Feb 12, 2014 · 6 comments

Comments

@benjchristensen
Copy link
Member

The various replay overloads ended up getting implemented in a private Subject implementation inside OperationReplay (https://github.com/Netflix/RxJava/blob/master/rxjava-core/src/main/java/rx/operators/OperationReplay.java?source=c#L699). This functionality needs to live on ReplaySubject itself.

This was brought up with some of the functionality added in: #753

Issues related to this are:

@katzseth22202
Copy link

Hi guys, I'll begin working on this.

@akarnokd
Copy link
Member

Does it need to solve issue #658 as well?

@benjchristensen
Copy link
Member Author

Yes it does, thanks for reminding me of that one.

@benjchristensen
Copy link
Member Author

This item is open to be worked on as @katzseth22202 has been pulled away to something else.

@benjchristensen
Copy link
Member Author

This is being done as part of #1211

@benjchristensen
Copy link
Member Author

Merged in #1223

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants