-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Collection of tiny issues detected by IntelliJ IDEA :) #1266
Comments
DavidMGross
added a commit
that referenced
this issue
May 27, 2014
Good catch. Should be |
Thanks @orangy for referencing these. |
Thanks @zsxwing for fixing that item and @DavidMGross for fixing Javadoc issues. |
Please continue submitting PRs to fix these and similar issues as they are found. |
benjchristensen
added a commit
that referenced
this issue
Jul 24, 2014
benjchristensen
added a commit
that referenced
this issue
Jul 24, 2014
I believe these are all done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Observable:
lift - parameter "lift" not documented
pivot - parameter "groups" not documented
merge - duplicate @return
range - if ((start + count) > Integer.MAX_VALUE) -- condition is always false
dematerialize - @throws Throwable not declared by method (as far as I can see it throws OnErrorNotImplementedException)
range, elementAt, forEach - duplicate @throws IllegalArgumentException
unsafeSubscribe - parameter 'subscriber' not documented
subscribe - hook.onSubscribeError(r); -- throws r, not the result of hook
ThrowObservable - "@return a reference to the subscription" on void method
RxJavaObservableExecutionHook.onSubscribeStart - typo in parameter name "observableInsance"
CompositeException - messagePrefix not used
(more to come)
The text was updated successfully, but these errors were encountered: