Skip to content

Commit

Permalink
Merge pull request #3231 from akarnokd/OperatorTimedLastSkipTake2x
Browse files Browse the repository at this point in the history
Operator takeLast time + size, skipLast time
  • Loading branch information
akarnokd committed Aug 28, 2015
2 parents 92d3c03 + db8c1e7 commit e7ce462
Show file tree
Hide file tree
Showing 3 changed files with 573 additions and 0 deletions.
85 changes: 85 additions & 0 deletions src/main/java/io/reactivex/Observable.java
Original file line number Diff line number Diff line change
Expand Up @@ -1412,4 +1412,89 @@ public static <T> Observable<T> fromFuture(Future<? extends T> future, long time
Observable<T> o = fromFuture(future, timeout, unit);
return o.subscribeOn(scheduler);
}

public final Observable<T> skipLast(long time, TimeUnit unit) {
return skipLast(time, unit, Schedulers.trampoline(), false, bufferSize());
}

public final Observable<T> skipLast(long time, TimeUnit unit, boolean delayError) {
return skipLast(time, unit, Schedulers.trampoline(), delayError, bufferSize());
}

public final Observable<T> skipLast(long time, TimeUnit unit, Scheduler scheduler) {
return skipLast(time, unit, scheduler, false, bufferSize());
}

public final Observable<T> skipLast(long time, TimeUnit unit, Scheduler scheduler, boolean delayError) {
return skipLast(time, unit, scheduler, delayError, bufferSize());
}

public final Observable<T> skipLast(long time, TimeUnit unit, Scheduler scheduler, boolean delayError, int bufferSize) {
Objects.requireNonNull(unit);
Objects.requireNonNull(scheduler);
if (bufferSize <= 0) {
throw new IllegalArgumentException("bufferSize > 0 required but it was " + bufferSize);
}
return lift(new OperatorSkipLastTimed<>(time, unit, scheduler, bufferSize, delayError));
}

public final Observable<T> takeLast(long time, TimeUnit unit) {
return takeLast(time, unit, Schedulers.trampoline(), false, bufferSize());
}

public final Observable<T> takeLast(long count, long time, TimeUnit unit) {
return takeLast(count, time, unit, Schedulers.trampoline(), false, bufferSize());
}

public final Observable<T> takeLast(long time, TimeUnit unit, boolean delayError) {
return takeLast(time, unit, Schedulers.trampoline(), delayError, bufferSize());
}

public final Observable<T> takeLast(long time, TimeUnit unit, Scheduler scheduler) {
return takeLast(time, unit, scheduler, false, bufferSize());
}

public final Observable<T> takeLast(long count, long time, TimeUnit unit, Scheduler scheduler) {
return takeLast(count, time, unit, scheduler, false, bufferSize());
}

public final Observable<T> takeLast(long time, TimeUnit unit, Scheduler scheduler, boolean delayError) {
return takeLast(time, unit, scheduler, delayError, bufferSize());
}

public final Observable<T> takeLast(long time, TimeUnit unit, Scheduler scheduler, boolean delayError, int bufferSize) {
return takeLast(Long.MAX_VALUE, time, unit, scheduler, delayError, bufferSize);
}

public final Observable<T> takeLast(long count, long time, TimeUnit unit, Scheduler scheduler, boolean delayError, int bufferSize) {
Objects.requireNonNull(unit);
Objects.requireNonNull(scheduler);
if (bufferSize <= 0) {
throw new IllegalArgumentException("bufferSize > 0 required but it was " + bufferSize);
}
if (count < 0) {
throw new IllegalArgumentException("count >= 0 required but it was " + count);
}
return lift(new OperatorTakeLastTimed<>(count, time, unit, scheduler, bufferSize, delayError));
}

public final Observable<List<T>> takeLastBuffer(int count) {
return takeLast(count).toList();
}

public final Observable<List<T>> takeLastBuffer(int count, long time, TimeUnit unit) {
return takeLast(count, time, unit).toList();
}

public final Observable<List<T>> takeLastBuffer(int count, long time, TimeUnit unit, Scheduler scheduler) {
return takeLast(count, time, unit, scheduler).toList();
}

public final Observable<List<T>> takeLastBuffer(long time, TimeUnit unit) {
return takeLast(time, unit).toList();
}

public final Observable<List<T>> takeLastBuffer(long time, TimeUnit unit, Scheduler scheduler) {
return takeLast(time, unit, scheduler).toList();
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,243 @@
/**
* Copyright 2015 Netflix, Inc.
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in
* compliance with the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software distributed under the License is
* distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See
* the License for the specific language governing permissions and limitations under the License.
*/

package io.reactivex.internal.operators;

import java.util.Queue;
import java.util.concurrent.TimeUnit;
import java.util.concurrent.atomic.*;

import org.reactivestreams.*;

import io.reactivex.Observable.Operator;
import io.reactivex.internal.queue.SpscLinkedArrayQueue;
import io.reactivex.internal.subscriptions.SubscriptionHelper;
import io.reactivex.internal.util.BackpressureHelper;
import io.reactivex.Scheduler;

public final class OperatorSkipLastTimed<T> implements Operator<T, T> {
final long time;
final TimeUnit unit;
final Scheduler scheduler;
final int bufferSize;
final boolean delayError;

public OperatorSkipLastTimed(long time, TimeUnit unit, Scheduler scheduler, int bufferSize, boolean delayError) {
this.time = time;
this.unit = unit;
this.scheduler = scheduler;
this.bufferSize = bufferSize;
this.delayError = delayError;
}

@Override
public Subscriber<? super T> apply(Subscriber<? super T> t) {
return new SkipLastTimedSubscriber<>(t, time, unit, scheduler, bufferSize, delayError);
}

static final class SkipLastTimedSubscriber<T> extends AtomicInteger implements Subscriber<T>, Subscription {
/** */
private static final long serialVersionUID = -5677354903406201275L;
final Subscriber<? super T> actual;
final long time;
final TimeUnit unit;
final Scheduler scheduler;
final SpscLinkedArrayQueue<Object> queue;
final boolean delayError;

Subscription s;

volatile long requested;
@SuppressWarnings("rawtypes")
static final AtomicLongFieldUpdater<SkipLastTimedSubscriber> REQUESTED =
AtomicLongFieldUpdater.newUpdater(SkipLastTimedSubscriber.class, "requested");

volatile boolean cancelled;

volatile boolean done;
Throwable error;

public SkipLastTimedSubscriber(Subscriber<? super T> actual, long time, TimeUnit unit, Scheduler scheduler, int bufferSize, boolean delayError) {
this.actual = actual;
this.time = time;
this.unit = unit;
this.scheduler = scheduler;
this.queue = new SpscLinkedArrayQueue<>(bufferSize);
this.delayError = delayError;
}

@Override
public void onSubscribe(Subscription s) {
if (SubscriptionHelper.validateSubscription(this.s, s)) {
return;
}
this.s = s;
actual.onSubscribe(this);
s.request(Long.MAX_VALUE);
}

@Override
public void onNext(T t) {
final Queue<Object> q = queue;

long now = scheduler.now(unit);

q.offer(now);
q.offer(t);

drain();
}

@Override
public void onError(Throwable t) {
error = t;
done = true;
drain();
}

@Override
public void onComplete() {
done = true;
drain();
}

@Override
public void request(long n) {
if (SubscriptionHelper.validateRequest(n)) {
return;
}
BackpressureHelper.add(REQUESTED, this, n);
drain();
}

@Override
public void cancel() {
if (cancelled) {
cancelled = true;

if (getAndIncrement() == 0) {
queue.clear();
s.cancel();
}
}
}

void drain() {
if (getAndIncrement() != 0) {
return;
}

int missed = 1;

final Subscriber<? super T> a = actual;
final SpscLinkedArrayQueue<Object> q = queue;
final boolean delayError = this.delayError;
final TimeUnit unit = this.unit;
final Scheduler scheduler = this.scheduler;
final long time = this.time;

for (;;) {

if (checkTerminated(done, q.isEmpty(), a, delayError)) {
return;
}

long r = requested;
boolean unbounded = r == Long.MAX_VALUE;
long e = 0L;

while (r != 0) {
boolean d = done;

Long ts = (Long)q.peek();

boolean empty = ts == null;

if (checkTerminated(d, empty, a, delayError)) {
return;
}

if (empty) {
break;
}

long now = scheduler.now(unit);

if (ts >= now - time) {
// not old enough
break;
}

// wait unit the second value arrives
if (q.size() == 1L) {
continue;
}

q.poll();

@SuppressWarnings("unchecked")
T v = (T)q.poll();

a.onNext(v);

r--;
e--;
}

if (e != 0L) {
if (!unbounded) {
REQUESTED.addAndGet(this, e);
}
}

missed = getAndSet(-missed);
if (missed == 0) {
break;
}
}
}

boolean checkTerminated(boolean d, boolean empty, Subscriber<? super T> a, boolean delayError) {
if (cancelled) {
queue.clear();
s.cancel();
return true;
}
if (d) {
if (delayError) {
if (empty) {
Throwable e = error;
if (e != null) {
a.onError(e);
} else {
a.onComplete();
}
return true;
}
} else {
Throwable e = error;
if (e != null) {
queue.clear();
a.onError(e);
return true;
} else
if (empty) {
a.onComplete();
return true;
}
}
}
return false;
}
}
}
Loading

0 comments on commit e7ce462

Please sign in to comment.