Merge pull request #816 from samuelgruetter/globalOnCompleted

One global onCompleted object
ReactiveX · Feb 5, 2014 · 64f20f9 · 64f20f9
2 parents 6756be3 + 8996277
commit 64f20f9
Showing 1 changed file with 6 additions and 2 deletions.
diff --git a/rxjava-core/src/main/java/rx/Notification.java b/rxjava-core/src/main/java/rx/Notification.java
@@ -26,6 +26,8 @@ public class Notification<T> {
     private final Throwable throwable;
     private final T value;
 
+    private static final Notification<Void> ON_COMPLETED = new Notification<Void>(Kind.OnCompleted, null, null);
+
     public static <T> Notification<T> createOnNext(T t) {
         return new Notification<T>(Kind.OnNext, t, null);
     }
@@ -34,12 +36,14 @@ public static <T> Notification<T> createOnError(Throwable e) {
         return new Notification<T>(Kind.OnError, null, e);
     }
 
+    @SuppressWarnings("unchecked")
     public static <T> Notification<T> createOnCompleted() {
-        return new Notification<T>(Kind.OnCompleted, null, null);
+        return (Notification<T>) ON_COMPLETED;
     }
 
+    @SuppressWarnings("unchecked")
     public static <T> Notification<T> createOnCompleted(Class<T> type) {
-        return new Notification<T>(Kind.OnCompleted, null, null);
+        return (Notification<T>) ON_COMPLETED;
     }
 
     private Notification(Kind kind, T value, Throwable e) {