This repository has been archived by the owner on Dec 5, 2019. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 258
This changes dependencies from ReactiveCocoa 2.x to ReactiveObjC 2.1.x #52
Open
anivaros
wants to merge
3
commits into
ReactiveCocoa:master
Choose a base branch
from
anivaros:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
github "ReactiveCocoa/ReactiveCocoa" ~> 2.4.3 | ||
github "ReactiveCocoa/ReactiveObjC" ~> 2.1.0 |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
github "Quick/Nimble" "v0.2.0" | ||
github "Quick/Quick" "v0.2.2" | ||
github "ReactiveCocoa/ReactiveCocoa" "v2.4.3" | ||
github "ReactiveCocoa/ReactiveObjC" "v2.1.0" | ||
github "jspahrsummers/xcconfigs" "0.7.1" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
{ | ||
"name": "ReactiveViewModel", | ||
"version": "0.4", | ||
"summary": "Model-View-ViewModel, using ReactiveCocoa.", | ||
"description": "ReactiveViewModel is a combination code/documentation project for building Cocoa applications using Model-View-ViewModel and ReactiveCocoa.\n\nBy explaining rationale, documenting best practices, and providing reusable library components, we want to make MVVM in Objective-C appealing and easy.", | ||
"homepage": "https://github.com/ReactiveCocoa/ReactiveViewModel", | ||
"license": { | ||
"type": "MIT", | ||
"file": "LICENSE.md" | ||
}, | ||
"authors": { | ||
"Alan Rogers": "[email protected]", | ||
"Just Spahr-Summers": "[email protected]", | ||
"Josh Abernathy": "[email protected]" | ||
}, | ||
"platforms": { | ||
"ios": "6.0", | ||
"osx": "10.8" | ||
}, | ||
"source": { | ||
"git": "https://github.com/ReactiveCocoa/ReactiveViewModel.git", | ||
"tag": "0.4" | ||
}, | ||
"source_files": "ReactiveViewModel/*.{h,m}", | ||
"requires_arc": true, | ||
"dependencies": { | ||
"ReactiveObjC": [ | ||
"~> 2.1" | ||
] | ||
}, | ||
"prepare_command": "find . \\( -regex '.*EXT.*\\.[mh]$' -o -regex '.*metamacros\\.[mh]$' \\) -execdir mv {} RAC{} \\;\nfind . -regex '.*\\.[hm]' -exec sed -i '' -E 's@\"(EXT.*|metamacros)\\.h\"@\"RAC\\1.h\"@' {} \\;\nfind . -regex '.*\\.[hm]' -exec sed -i '' -E 's@<ReactiveObjC/(EXT.*)\\.h>@<ReactiveObjC/RAC\\1.h>@' {} \\;\n" | ||
} | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this podspec need to be pushed somewhere? Or is inclusion in this repo enough?
I'm not sure who maintains the podspec.
The rest of this PR is great.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I found this podspec here and updated it.
I don't know right way to upgrade it to new version too 😕
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind splitting the podspec change into a separate PR?