Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add action types #257

Merged
merged 4 commits into from
Aug 14, 2022
Merged

Add action types #257

merged 4 commits into from
Aug 14, 2022

Conversation

LeoColman
Copy link
Contributor

Github Actions YAML usually isn't as useful as it could be.

https://github.com/krzema12/github-actions-typing

This project setup a way to define types for github actions inputs to build a type-safe DSL.

This commit implements both the typing for this action and the workflow to verify it.

@LeoColman LeoColman mentioned this pull request Jul 16, 2022
Closed
@LeoColman
Copy link
Contributor Author

Hey guys!
Dou you think this is a good PR? Let me know if you think any changes should be made
@ychescale9

ychescale9
ychescale9 approved these changes Aug 14, 2022
View reviewed changes
Copy link
Member

@ychescale9 ychescale9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@ychescale9 ychescale9 merged commit a410b40 into ReactiveCircus:main Aug 14, 2022
ychescale9 added a commit that referenced this pull request Sep 20, 2022
@ychescale9
Merge branch 'main' into release/v2
d7b53dd 
* main:
  Prepare for release 2.26.0.
  Bump @actions/core from 1.6.0 to 1.9.1 (#262)
  Add action types (#257)
  Update documentation (#255)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ychescale9 ychescale9 ychescale9 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LeoColman @ychescale9