Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The thermo parameters of ring(12dioxetane) fitted with CBS-QB3 calculation results #327

Merged
merged 1 commit into from
May 31, 2019

Conversation

hwpang
Copy link
Contributor

@hwpang hwpang commented May 6, 2019

The thermo parameters of ring(12dioxetane) were fitted by Hao-Wei Pang in May 2019 using CBS-QB3 calculations for oxygen-butadiene polymerization from Duminda Ranasinghe in April 2019.

@hwpang hwpang requested a review from mliu49 May 6, 2019 18:12
Copy link
Contributor

@mliu49 mliu49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I made minor comments.

For documentation purposes, since I went through the effort to look this up, the original values were imported from RMG-Java, where there was also no source listed (see git blame here).


shortDesc = u"""Calculations from Duminda Ranasinghe""",
longDesc =
u""""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extra quote was added here.

shortDesc = u"""Calculations from Duminda Ranasinghe""",
longDesc =
u""""
Based on CBS-QB3 calculations from Duminda Ranasinghe in 05/2019, fitted by Hao-Wei Pang
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add what molecule(s) the calculations were for?

@mliu49
Copy link
Contributor

mliu49 commented May 6, 2019

Also, please make sure to rebase this onto current master. You can do so after addressing my comments.

@hwpang hwpang force-pushed the OxygenButadiene branch from c38d093 to fd9e422 Compare May 29, 2019 21:53
@mliu49
Copy link
Contributor

mliu49 commented May 30, 2019

One last thing - git commit messages have a "recommended" style so that they look nice on GitHub or when you do git log. Notice how GitHub cuts off your commit message at 69 characters and puts the rest in the description section.

Here's an example of what a full commit message might look like:

Short title explaining what the commit does, ideally <70 characters

Optional longer description of motivation for the commit or the approach
taken for the change.
- Note the single line break between this section and the title.
- It's recommended to wrap the text at ~70 characters so that it's easier
to read in git clients which don't wrap text or on the command line.
- This section can be as long as you want.

Note that adding the optional long description is not possible via git commit -m, which only lets you provide the short title. To edit the commit message for this PR, you can use git commit --amend, which will open the commit message in your default editor.

Thermo parameters of ring(12dioxetane) were fitted by Hao-Wei Pang in May 2019 using CBS-QB3 calculations for oxygen-butadiene polymerization from Duminda Ranasinghe in April 2019.
@hwpang hwpang force-pushed the OxygenButadiene branch from fd9e422 to 548e46d Compare May 30, 2019 21:06
@hwpang
Copy link
Contributor Author

hwpang commented May 30, 2019

Thanks for your comment! It is really helpful. I've amended the commit and force pushed it. Please review it when you are available.

@mliu49 mliu49 merged commit af0ecee into master May 31, 2019
@mliu49 mliu49 deleted the OxygenButadiene branch May 31, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants