-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The thermo parameters of ring(12dioxetane) fitted with CBS-QB3 calculation results #327
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! I made minor comments.
For documentation purposes, since I went through the effort to look this up, the original values were imported from RMG-Java, where there was also no source listed (see git blame here).
input/thermo/groups/ring.py
Outdated
|
||
shortDesc = u"""Calculations from Duminda Ranasinghe""", | ||
longDesc = | ||
u"""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra quote was added here.
input/thermo/groups/ring.py
Outdated
shortDesc = u"""Calculations from Duminda Ranasinghe""", | ||
longDesc = | ||
u"""" | ||
Based on CBS-QB3 calculations from Duminda Ranasinghe in 05/2019, fitted by Hao-Wei Pang |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you add what molecule(s) the calculations were for?
Also, please make sure to rebase this onto current master. You can do so after addressing my comments. |
One last thing - git commit messages have a "recommended" style so that they look nice on GitHub or when you do Here's an example of what a full commit message might look like:
Note that adding the optional long description is not possible via |
Thermo parameters of ring(12dioxetane) were fitted by Hao-Wei Pang in May 2019 using CBS-QB3 calculations for oxygen-butadiene polymerization from Duminda Ranasinghe in April 2019.
Thanks for your comment! It is really helpful. I've amended the commit and force pushed it. Please review it when you are available. |
The thermo parameters of ring(12dioxetane) were fitted by Hao-Wei Pang in May 2019 using CBS-QB3 calculations for oxygen-butadiene polymerization from Duminda Ranasinghe in April 2019.