-
Notifications
You must be signed in to change notification settings - Fork 232
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uncertainty fixes and user experience improvement #1593
Merged
Merged
Changes from all commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
1b88161
Automatically format rmgpy.tools.uncertainty
mliu49 ad168ba
Automatically format rmgpy.tools.muq
mliu49 ea79bcd
Adjust file paths for local uncertainty analysis
mliu49 e1bbf01
Automatically retrieve internal indices
mliu49 a27e59a
Return uncertainty results
mliu49 abc551c
Retrieve uncertainties for uncorrelated global analysis
mliu49 cfb7607
Perform PCE fitting in ln(x) space
mliu49 d2c213d
Bugfix in rmgpy.tools.canteraModel
mliu49 ebdcabb
Add reactionSystemIndex argument to Uncertainty.localAnalysis
mliu49 11c7cdb
Add function to process and prettify local uncertainty results
mliu49 3b39af9
Add input block for uncertainty settings
mliu49 6852f51
Enable automatic uncertainty analysis following RMG job
mliu49 467f436
Replace labels with species in sensConditions
mliu49 b7d5fe9
Bugfix: Cast parsed indices to int when loading sensitivity results
mliu49 cfd07f0
For local uncertainty, save RMG index for reactions
mliu49 879d7db
Refactor output printing for global uncertainty analysis
mliu49 da82473
Save extra species created for correlated uncertainty analysis
mliu49 e3cf9ba
Split run_uncertainty_analysis off of run_model_analysis
mliu49 1870e87
Move plot_sensitivity to rmgpy.tools.plot
mliu49 2e55f78
Enable simulate.py to run uncertainty analysis
mliu49 b8662d4
Make file naming in initializeLog more generic
mliu49 37dbd53
Fix formatting issue in writing Chemkin files
mliu49 035e481
Update findParameterSourcesAndAssignUncertainties.ipynb
mliu49 8494c36
Bugfix: Disable species constraints for training reactions
mliu49 92bd96b
Check if global analysis parameters are already in list
mliu49 9502978
Update localUncertainty.ipynb and example models
mliu49 75a9ff6
Make ln(mole fraction) an option for global uncertainty analysis
mliu49 65f3db0
Update globalUncertainty.ipynb
mliu49 3d36c5c
Update Cantera simulation IPython notebooks and data files
mliu49 3a06b6a
Inform user if local uncertainty is being enabled
mliu49 a3ab31d
Add documentation on using uncertainty options in input file
mliu49 7e15900
Add note about uncertainty to simulate.py documentation
mliu49 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Define PCE?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added the abbreviation to the first mention of Polynomial Chaos Expansion earlier in the section (line 806).