Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved restart behaviour #64

Merged
merged 15 commits into from
Feb 21, 2019
Merged

Improved restart behaviour #64

merged 15 commits into from
Feb 21, 2019

Conversation

alongd
Copy link
Member

@alongd alongd commented Feb 16, 2019

  • Allow a restart file to be loaded directly in main not necessarily passing through ARC.py, so API could use input/restart files
  • Improved handling of monoatomics when restarting
  • Improved handling of scans in restart

Also improved fig size of thermo parity plots

@alongd alongd added Type: UX User Experience Topic: Restart labels Feb 16, 2019
@codecov
Copy link

codecov bot commented Feb 16, 2019

Codecov Report

Merging #64 into master will increase coverage by 6.95%.
The diff coverage is 52.05%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
+ Coverage   32.79%   39.74%   +6.95%     
==========================================
  Files          19       19              
  Lines        4342     4380      +38     
  Branches     1137     1144       +7     
==========================================
+ Hits         1424     1741     +317     
+ Misses       2681     2340     -341     
- Partials      237      299      +62
Impacted Files Coverage Δ
arc/job/submit.py 100% <ø> (ø) ⬆️
arc/scheduler.py 18.14% <16.66%> (+6.3%) ⬆️
arc/species.py 60.83% <37.5%> (+1.19%) ⬆️
arc/main.py 43.01% <64%> (+9.78%) ⬆️
arc/processor.py 58.87% <71.42%> (+49.74%) ⬆️
arc/plotter.py 30.99% <75%> (+16.86%) ⬆️
arc/reaction.py 42.35% <0%> (ø) ⬆️
arc/rmgdb.py 73.97% <0%> (+1.36%) ⬆️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8548de...e520407. Read the comment docs.

not necessarily passing through ARC.py, so API could use input/restart
files
Save the restart path even if scan failed, since this is the criterion
to re-running a scan in restart mode
- Flexible figure size: adjust according to the number of species,
maintaining a minimum height and a fixed width
-long entry description
Since save_project_info_file also updates the long library description
needed for processor
to include max_e and invalidation_reason
in terms of logging the invalidation reason and symmetry
to adjast for the additional e_max parameter returned by
determine_rotor_symmetry()
@alongd alongd merged commit 1fd4313 into master Feb 21, 2019
@alongd alongd deleted the restart branch February 21, 2019 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant