Fix pathless route's match when parent is null #5964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The logic for this has been moved to matchPath. When automatic path resolving is added, matchPath will need access to the parent match, so we will need to pass that argument to matchPath eventually anyways. When a parent match is null, a match object with default values is returned by matchPath. This match object should not be relied upon for resolving paths, but it will allow a <Route> that uses the component or render prop to render. Fixes #4695
This is only an issue when you use <Route children>. If you render a pathless <Route> inside of a <Route children>, you must also use <Route children> (instead of <Route render> or <Route component>). This commit also switches withRouter to using <Route children> instead of <Route render> so that it works when the parent match is null.
This was referenced Feb 22, 2018
|
Since I've got the 👍 from @pshrmn's ownership of the original PR, and I also agree this is sensible to merge in, I'm going to do it. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recreating #4704 under a branch on the main repo.
Original PR post:
This moves the logic for getting the match object for a pathless
<Route>matchPath. When automatic path resolving is added,matchPathwill need access to the parentmatch, so we will need to pass that argument tomatchPatheventually anyways.When a parent
matchisnull, a match object with default values is returned bymatchPath. This match object should not be relied upon for resolving paths, but it will allow a<Route>that uses thecomponentorrenderprop to render.Fixes #4695