-
Notifications
You must be signed in to change notification settings - Fork 115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hooks implementation #149
Merged
edorivai
merged 29 commits into
ReactTraining:master
from
tstirrat15:hooks-implementation
May 27, 2020
+294
−11,523
Merged
Changes from 21 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
593f125
npm audit fix
tstirrat15 997777c
Bump react versions, add hooks eslint
tstirrat15 e1436ee
Update package.lock
tstirrat15 dfc2b2c
Add hook rules to eslint
tstirrat15 21a65f5
Add testing library to project
tstirrat15 e5935cf
First pass with all tests working
tstirrat15 3fc6049
Refactor tests to use testing-library patterns
tstirrat15 92f7c72
Refactor renderStrict to use testing-library
tstirrat15 1444394
Make nested ternaries explicit using parentheses
tstirrat15 e18f27c
Extract hook logic and export new function
tstirrat15 c489cbb
Add useMedia to exports
tstirrat15 97c1d0c
Explicitly tell rollup to use named exports
tstirrat15 9459522
Remove TODO
tstirrat15 02602bb
Add exports: named, be explicit about babelHelpers, swap uglify for t…
tstirrat15 a59d672
Upgrade rollup and friends to latest
tstirrat15 5f89897
Upgrade rollup and friends to latest
tstirrat15 f491714
Check it out! smaller bundles
tstirrat15 8619b1e
Remove unused class property babel transform
tstirrat15 a1e5d9e
Bump babel-jest version, remove now-unused transformation
tstirrat15 37c7086
Update size snapshot
tstirrat15 fe58da4
Upgrade the babels too
tstirrat15 0a30e06
Add babel bridge for jest's benefit
tstirrat15 49758b4
Switch from npm to yarn
tstirrat15 0c5e83d
Mild reformatting of babelrc
tstirrat15 655b58a
move travis.yml to use yarn
tstirrat15 8cefd6f
Fix proptypes errors
tstirrat15 1144c64
Remove lockfile
tstirrat15 256b02c
Turn off package.lock for the repository
tstirrat15 13cd76d
Prevent jest errors from showing up in stderr output
tstirrat15 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,26 +1,26 @@ | ||
{ | ||
"esm/react-media.js": { | ||
"bundled": 8066, | ||
"minified": 4215, | ||
"gzipped": 1360, | ||
"bundled": 7913, | ||
"minified": 3466, | ||
"gzipped": 1246, | ||
"treeshaked": { | ||
"rollup": { | ||
"code": 3016, | ||
"import_statements": 322 | ||
"code": 364, | ||
"import_statements": 187 | ||
}, | ||
"webpack": { | ||
"code": 4345 | ||
"code": 3689 | ||
} | ||
} | ||
}, | ||
"umd/react-media.js": { | ||
"bundled": 39317, | ||
"minified": 12555, | ||
"gzipped": 4351 | ||
"bundled": 38897, | ||
"minified": 11948, | ||
"gzipped": 4235 | ||
}, | ||
"umd/react-media.min.js": { | ||
"bundled": 15687, | ||
"minified": 5539, | ||
"gzipped": 2274 | ||
"bundled": 15270, | ||
"minified": 5110, | ||
"gzipped": 2190 | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's a separate ESLint plugin for the rules of hooks, which will be nice for anyone working on this library.