Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate outside position for solid effect #83

Closed
andrejunges opened this issue Mar 7, 2016 · 5 comments
Closed

Calculate outside position for solid effect #83

andrejunges opened this issue Mar 7, 2016 · 5 comments

Comments

@andrejunges
Copy link
Contributor

I think we should calculate the outside positions for solid effect as well..
We dont have to follow the mouse position (of course) but is there a case why we shouldn't considerate the outside positions for it?
screen shot 2016-03-07 at 1 38 19 pm
@wwayne
Copy link
Collaborator

wwayne commented Mar 7, 2016

Hi @andrejunges , what do you mean by saying calculate the outside positions? I guess it is: for example, if the tooltip in top is out of the web page, it should be changed to bottom position automatically.

@andrejunges
Copy link
Contributor Author

exactly @wwayne

@andrejunges
Copy link
Contributor Author

was there a reason to not implement it? @wwayne

@wwayne
Copy link
Collaborator

wwayne commented Mar 9, 2016

@andrejunges No, just because no time for this at the moment, may do some trying this weekend.

@andrejunges andrejunges mentioned this issue Mar 10, 2016
Merged
wwayne added a commit that referenced this issue Mar 10, 2016
@wwayne
Merge pull request #84 from andrejunges/master
707d915 
Add logic to handle outside cases for solid tooltips #83
@wwayne
Copy link
Collaborator

wwayne commented Mar 10, 2016

Thanks @andrejunges, support from 1.1.4

@wwayne wwayne closed this as completed Mar 10, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@andrejunges @wwayne