-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All tooltips are visible instead of current #283
Comments
what with this issue? |
Hey @wwayne, any chance we can get this fixed? Steps to reproduce the problem:
I expect that the first tooltip is hidden (as per globalEventOff='click'). Instead, both tooltips are displayed. |
Is there a fix planned for this issue? I'm guessing not given its age. It can apparently be resolved by only having one tooltip component on a given page, but it'd be great to not have to refactor the way tooltips have been implemented across our application just to work around this. |
Pinging @aronhelser as he seems to be more active lately |
I won't be able to solve it, but a PR would be welcome. Seems like looking at what happens inside the globalEventOff handler is a place to start... |
Use isCapture prop to hide tooltip when another is clicked. See issue ReactTooltip/react-tooltip#283 and the pull request ReactTooltip/react-tooltip#433
@aronhelser Please see the referenced PR and the my updated demo app. This seems to have solved the issue. Please review, I'm not sure if I dealt with this correctly. I used the Thanks! |
Copied from #89 since it still occurs:
When several tooltips are instantiated on a single page, the data-event click doesn't act fully as a toggle to hide all active tooltips. Not sure if this is the desired behavior but it would make sense that only the current tooltip be activated at a time.
The text was updated successfully, but these errors were encountered: