Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

attributes #159

Closed
oszkarjona-tradedoubler opened this issue Jul 29, 2016 · 5 comments
Closed

attributes #159

oszkarjona-tradedoubler opened this issue Jul 29, 2016 · 5 comments

Comments

@oszkarjona-tradedoubler

Hi,
Is it possible to set attributes like role or aria-* on ReactTooltip?
THX

@wwayne
Copy link
Collaborator

wwayne commented Jul 30, 2016

I think it is possible, but need update the tooltip component, the tooltip component will generate a <div></div> actually, so we just expose an endpoint on ReactTooltip that can set aria-* on that div element

wwayne added a commit that referenced this issue Aug 3, 2016
wwayne added a commit that referenced this issue Aug 3, 2016
Add support for aria- and role props #159
@wwayne
Copy link
Collaborator

wwayne commented Aug 3, 2016

Supported in 3.1.4, you can add <ReactTooltip aria-value="xxx" role="xxx" /> for example

@wwayne wwayne closed this as completed Aug 3, 2016
@oszkarjona-tradedoubler
Copy link
Author

cool 👍

@daceynolan
Copy link

@wwayne I see that this was updated to support value and role. However, when using the screenreader, my aria-value is never being announced and the role is making it announced constantly. Do you have a workaround to get this to work with screenreaders?

@aronhelser
Copy link
Collaborator

We have no maintainers who are actively developing this tool, so if you can debug and submit a PR, that is the way we can address this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants